Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CSS to avoid hiding the save and reboot button #2198

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Sep 21, 2024

Before
INAV Configurator - before

After
INAV Configurator - after

@MrD-RC MrD-RC added this to the 8.0 milestone Sep 21, 2024
@MrD-RC MrD-RC merged commit c4a76a4 into master Sep 21, 2024
5 checks passed
@MrD-RC MrD-RC deleted the MrD_Resize-UI-for-smaller-resolution-displays branch September 21, 2024 16:40
@Jetrell
Copy link

Jetrell commented Oct 18, 2024

@MrD-RC I'm not sure if it effects some monitor screens differently.
This is what I had before this commit.

before

And after. Which has moved the Save reboot button higher and left a blank space below it. Shrinking the dialog size..
It effects all tabs with Save reboot button, except the Configuration tab.

after

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 18, 2024

Are you on mac or windows? Which browser?

@Jetrell
Copy link

Jetrell commented Oct 18, 2024

Windows... I use Firefox.
I loaded Chrome as default for a test. And that returned it to what it was.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 18, 2024

Damn browsers and their different implementations. I'm using Brave, which is based on Chromium. Actually, I don't get why that impacts the application. The whole thing used to be running as. Chrome app. I guess moving to Electron had changed that?

@Jetrell
Copy link

Jetrell commented Oct 18, 2024

Damn browsers and their different implementations

It seems that way. I also tried it with Opera and Edge browsers.. Unfortunately both of them had the same issue as Firefox.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 18, 2024

I might have to try some nasty browser specific css 😕

@Jetrell
Copy link

Jetrell commented Oct 18, 2024

I gave it a go with Brave as you use. And it worked.
I also thought Opera should work. Because it has a Chromium license.. And after hammering the Flush Setting Cache button a few times. I got it to work... But I still couldn't get Firefox and Edge to work when doing the same. Even after an FC and PC reboot.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Nov 2, 2024

Reverting as the issue seems to only affect some pages, such as configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants