-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ukrainian translation for the INAV Configurator #2196
Adding Ukrainian translation for the INAV Configurator #2196
Conversation
…o review, suggest some change or fix errors - please use crowdin to send your suggestions. https://crowdin.com/project/inav-in-ukrainian
дякую |
The one thing I know how to check looks good - Lines 14-16 can also be added to the English file, so that when it's in English it knows how to display the option to switch. |
@sensei-hacker , thanks. I've updated the English one as well. |
@smsnvc no need to thank me. You guys have put in all the work. It's always great to see another language supported. The only issue is when new things get added, the translations are also needed. Personally, my Ukrainian is about 10-15 words. So I would be pretty useless at this stage 🤣 Thanks guys, we really appreciate it. |
@MrD-RC , in such threads there is usually a lot for what a person can say thanks. For comments that make us feel not so stranded or for your work on INAV or for your helpful videos. We've managed to keep translations of ESC, ELRS, and Betaflight configurators in sync with the code base. So hopefully INAV will join the family. And there will be more work for the developers since not all strings are translatable. For instance, in the OSD setup. |
Thanks for addressing it, looks cool.
There is usually a question to what degree to translate, to what extend. PID vs CLI vs GPS etc. There are some rules, for GPS is rarely translated (https://uk.wikipedia.org/wiki/GPS). Same as names of the technologies like DSHOT, SmartAudio or UART. With PID it's a different story, becuase it's taught in schools and universities as cyrilic. And when you read it in the text, it's quite confusing to see latin P, which is written the same as Cyriliс Р. And if you use purely English language for everything in PID (including P-Term, Feedforward), we come to the situation when the users do not understand P-Term vs P (as a multiplier). Novice pilots can't translate the word term( because it has ~30 different translations). We had this constant struggle while translating the Betaflight, which had PID without translation initially. And at some point we understood that we should use Ukrainian variants to deliver consistent experiece. Our task is to make the translation look familiar, accessible, encourages to read and learn, give "I can do it" attitude. I understand, that for those who are proficient in English, used English interface, it may look challenging. They may not see the benefits in using the translated interface. This is fine. Our target audience for the translated interface has challenges with English and would prefer to read explanations in their native language. |
@smsnvc Thanks. Now I see that your investigation into this topic was much deeper than mine so let's leave these things as it is, thank you. @MrD-RC @sensei-hacker FYI from my side as a native Ukrainian speaker everything looks good in this PR. |
дуже добре |
Based on the last two comments, it sounds like no further changes are needed? |
@sensei-hacker Yes, everything looks good. Also, I just created a side PR with css fix for the sensors block: #2200 |
To me it looks good enough. |
@sensei-hacker it looks like @smsnvc is still pushing changes to the branch. @smsnvc and @bfmvsa let us know when you both believe this is ready. Is this pulled from the most recent master? |
@MrD-RC , sorry, decided to translate your latest strings in messages while it's not merged yet. |
@MrD-RC In my opinion, this is a good quality working version of translation and it could be merged. |
The idea of translation was discussed with @sensei-hacker, who said that it's possible in general in June 2024.
If you want to review, suggest some change or fix errors - please use crowdin to send your suggestions, because it is a source and an instrument for translations. Modifying in different places will make it more difficult to merge
https://crowdin.com/project/inav-in-ukrainian
I've tried to review and use some of the good suggestions AndrewKZV introduced in their translation: iNavFlight/inav#10283