Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy OSD layout for electron #2183

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

error414
Copy link
Contributor

It's fix for eletron, it seems approach to promises is not same in NWJS and electron.

@mmosca mmosca requested a review from MrD-RC September 10, 2024 19:53
@Jetrell
Copy link

Jetrell commented Sep 10, 2024

I can confirm this function was broken for Windows.. It wouldn't save the pasted OSD page.
However this commit has now fixed the issue. 👍

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 8, 2024

I've just come across this error. If @Jetrell has tested and it is fixed. I'm happy with that.

@MrD-RC MrD-RC added this to the 8.0 milestone Oct 8, 2024
@MrD-RC MrD-RC merged commit ae0f6a8 into iNavFlight:master Oct 8, 2024
5 checks passed
Copy link
Collaborator

@MrD-RC MrD-RC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants