Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme draft, Flat UI #2157

Closed
wants to merge 9 commits into from
Closed

Conversation

bfmvsa
Copy link
Contributor

@bfmvsa bfmvsa commented Aug 3, 2024

Hello team,

Please check out dark mode for INAV. To select dark mode please use the selector in the options tab:
screenshot 2024-08-04 at 00 02 49

Sorry for the huge commit, but I'm not sure how to do it properly in another way.
General changes in this PR:

  1. Created 2 CSS files with CSS variables (for dark mode and regular one).
  2. Partially updated existing CSS files to use variables.
  3. Removed gradients and box shadows to make UI flat.
  4. Updated some svg images to look good on the dark and light background.
  5. Updated Open Sans font to use font-weight property instead of using different font families for bold text.
  6. Different small fixes, and improvements.

Please note that tabs Mixer, Tunning, Advanced Tunning, and Alignment are not fixed according to dark mode. These tabs are not accessible to me for some reason at the moment (Infinity loading). [Fixed]

These changes are phase 1.
In the second phase, I'm planning to create common classes for generic elements such as buttons, tables, grid system, etc and replace a lot of existing CSS + HTML with them.

Some screenshots:
screenshot 2024-08-04 at 00 13 35
screenshot 2024-08-04 at 00 13 42
screenshot 2024-08-04 at 00 14 00

@mmosca
Copy link
Collaborator

mmosca commented Aug 3, 2024

Try reseting the settings cache, as that can cause issues. Also, make sure your fc has a recent inav8 firmware

@b14ckyy
Copy link
Collaborator

b14ckyy commented Aug 3, 2024

Personally not a Dark Mode user but that looks great! Especially OLED Laptop screen users will be thankful.

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 4, 2024

Hi @mmosca
Thanks, looks like resetting cache fixed issue with Alignment tab, bu It still have the issue with Mixer, Tunning, Advanced Tunning. The problem looks like the same for all tabs:
RangeError: Offset is outside the bounds of the DataView
screenshot 2024-08-04 at 09 23 49

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 4, 2024

Regarding inav8 firmware for fc, where can I find it? please advice.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Aug 4, 2024

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 4, 2024

@b14ckyy Thanks, I just temporarily commented that line of code and it worked for me.
Now tabs do not look so much bright as they used to, but look good for dark as well

screenshot 2024-08-04 at 11 03 39 screenshot 2024-08-04 at 11 03 29

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

Hi @mmosca Thanks, looks like resetting cache fixed issue with Alignment tab, bu It still have the issue with Mixer, Tunning, Advanced Tunning. The problem looks like the same for all tabs: RangeError: Offset is outside the bounds of the DataView screenshot 2024-08-04 at 09 23 49

You should stil try firmware 8.0.0.

image

Your issues are likely caused by running new configurator against older firmware.

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 4, 2024

@mmosca thanks. BTW why firmware version for inav 8 is not visible in the configurator 8?
screenshot 2024-08-04 at 16 26 50

@mmosca
Copy link
Collaborator

mmosca commented Aug 4, 2024

@mmosca thanks. BTW why firmware version for inav 8 is not visible in the configurator 8? screenshot 2024-08-04 at 16 26 50

Because it is not a stable release. you need to select the option to show pre-release firmware.

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 4, 2024

@mmosca I completely forgot about this checkbox, it helped, thanks a lot!

@mmosca
Copy link
Collaborator

mmosca commented Aug 8, 2024

@bfmvsa did you cover all tabs now, or are you still having issues?

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 8, 2024

@mmosca I've covered everything I could see. I've used plane and multirotor targets for tests.

Please note that I didn't spend a lot of time on some small issues like a little bit of different padding or responsive design, because I'm planning (already have started the work) to create some app-wide classes for tables, inputs, grid system, etc. and use them across the configurator

@bfmvsa bfmvsa marked this pull request as draft August 14, 2024 19:10
@bfmvsa
Copy link
Contributor Author

bfmvsa commented Aug 15, 2024

Hi @mmosca @b14ckyy
If you don't mind I'll delete this PR and replace it with PR with proper attention to detail. But another PR will include even more changes. I'm trying to concentrate only on HTML + CSS and don't touch much JS to simplify future tests. But there will be changes in JS as well.

@mmosca
Copy link
Collaborator

mmosca commented Aug 15, 2024

Hi @mmosca @b14ckyy If you don't mind I'll delete this PR and replace it with PR with proper attention to detail. But another PR will include even more changes. I'm trying to concentrate only on HTML + CSS and don't touch much JS to simplify future tests. But there will be changes in JS as well.

Up to you. :)

@bfmvsa bfmvsa closed this Aug 16, 2024
@mmosca
Copy link
Collaborator

mmosca commented Aug 16, 2024

I don't mind a long running pr. You can keep it as a draft if it is not done. That allows you to run the ci checks and makes it easier to download a zip and test :)

@bfmvsa bfmvsa deleted the dark-theme branch September 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants