Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL: adjusted SITL tab (built-in serial receiver support) #1849

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

RomanLut
Copy link
Contributor

@RomanLut RomanLut commented Oct 12, 2023

Accompanying submit for iNavFlight/inav#9365

NOTE: SITL executables in resources folder of inav configurator should be updated from inav repository after merging inav PR!

updated SITL executables
@RomanLut RomanLut changed the title adjusted SITL tab (built-in serial receiver support) SITL: adjusted SITL tab (built-in serial receiver support) Oct 12, 2023
@RomanLut RomanLut marked this pull request as ready for review October 12, 2023 17:19
@RomanLut RomanLut force-pushed the submit-serial-receiver branch from cc33a16 to 3022569 Compare November 14, 2023 04:04
@mmosca mmosca mentioned this pull request Apr 27, 2024
@mmosca
Copy link
Collaborator

mmosca commented Apr 27, 2024

@RomanLut can you merge the latest master, to fix the conflicts?

@mmosca mmosca added this to the 8.0 milestone Apr 27, 2024
@RomanLut
Copy link
Contributor Author

  1. Checked "Serial FC proxy" mode in Windows only.

Other functionality can not be tested because serial receivers can not be selected in SITL anymore: iNavFlight/inav#9986

  1. SITL Executables has to be updated in Configurator package, a least from here: https://github.com/iNavFlight/inav/actions/runs/8024919315
    (I think I am not allowed to submit executables in PR)

@mmosca
Copy link
Collaborator

mmosca commented Apr 29, 2024

I can update the SITL binaries based on latest master from iNavFlight/inav#9988.

Can you remove the Ser2TCP binaries in this pr as, as they won't be needed?

@stronnag Any last minute objections on merging this one?

@stronnag
Copy link
Collaborator

stronnag commented Apr 29, 2024

This PR is working correctly with the current SITL, so I have no issues with merging it.

  • The Windows SITL binary currently attached should be removed (as well as all ser2tcp)

Additionally the PATHs wlll need to be cleaned up at some time. At the modent it's a bit of mess, as we have resources/sitl/<OS> at build time and resources/app/resources/sitl/<OS> post install.

But that can be addressed after merge.

@mmosca mmosca merged commit fe6dc45 into iNavFlight:master Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants