Fix maximum symbol. #160
Open
Fix maximum symbol. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Replace "\192" and "\192" symbols with drawed up and up arrows.
|
Have you tested this on OpenTX ? The reason for the issue is because EdgeTX changed the fonts (to a UTF-8 font for localisation). |
|
The bug is not present on OpenTX 2.3.15. The fixed version works with OpenTX with no visual difference. The character is not available in EdgeTX, or at least is not documented in here https://luadoc.edgetx.org/appendix/fonts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Taranis, it is possible to switch between displaying actual and maximum values, using the rotary control. The symbol is displayed to signify the values are maximum/minimum. This is implemented with drawing text with special characters "\192" and "\193".
On my version and hardware, edgetx v2.10.5, opentx-telemetry-widget 2.2.5, transmitter taranis qx7 access, the characters are not displayed - the space on display is blank.
I propose to replace the special characters with up and down arrow drawed with "lcd.drawLine" and "lcd.drawPixel".