-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local support for Somfy Developer Mode #441
Conversation
iMicknl
commented
Apr 4, 2022
•
edited
Loading
edited
af0b069
to
562d327
Compare
pyoverkiz/client.py
Outdated
cafile=os.path.dirname(os.path.realpath(__file__)) | ||
+ "/overkiz-root-ca-2048.crt" | ||
) | ||
self._ssl_context = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSL check removed for now. We can just pass a session that does not verify SSL.
aef0464
to
3c3f24a
Compare
pyoverkiz/client.py
Outdated
@@ -122,6 +126,10 @@ def __init__( | |||
|
|||
self.session = session if session else ClientSession() | |||
|
|||
if "/enduser-mobile-web/1/enduserAPI/" in server.endpoint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to add a property named for instance. support_local
. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was in doubt about this one as well... In the end I would love to see something like this (#321), where we define the auth mechanism in the OverkizServer
definition.
Eventually that would be even better, since we can than easily pick any authentication method, and we don't need an extra property just for local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add local support to models * Add local event tests * Fix local event listener * Add local API support * Add first start to verify local cert * Implement all local endpoints * Local fixesak * Add extra test * Add Unknown Object exception * Bugfix * Remove SSL check for now * Add AccessDeniedToGatewayException * Simplify local check