Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TypeError: 'WhereBucketValue' object is not subscriptable #401 #429

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

GSzabados
Copy link
Contributor

This should handle the error, as it is already handled a few lines above the same way.

Should fix #401

(To reproduce the error, change the name of a Protect to a custom one.)

…knl#401

This should handle the error, as it is already handled a few lines above the same way.
@GSzabados GSzabados requested a review from iMicknl as a code owner February 17, 2025 23:06
@GSzabados
Copy link
Contributor Author

Should fix also #411

@iMicknl iMicknl requested a review from Copilot February 18, 2025 22:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

custom_components/nest_protect/init.py:193

  • Ensure that the behavior of bucket_value.wheres is covered by tests to verify it is iterable and that area.where_id and area.name are valid attributes.
for area in bucket_value.wheres:
@iMicknl iMicknl merged commit ca5b16b into iMicknl:beta Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants