Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clarify pin-out #91

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix/clarify pin-out #91

merged 1 commit into from
Jul 28, 2024

Conversation

jamesmyatt
Copy link
Contributor

I think the pin numbers have the opposite order. My E7 matches the colour order and locations but the pin numbers are the opposite ones.

@jamesmyatt jamesmyatt requested a review from iMicknl as a code owner July 14, 2024 15:01
@iMicknl
Copy link
Owner

iMicknl commented Jul 14, 2024

I was actually planning to revamp the README and remove the RJ45 colors, naming the pinout by numbers (as in #67). What do you think?

@jamesmyatt
Copy link
Contributor Author

I think the colours are useful. Many people will take an old Cat5 cable and chop an end off then wonder which colours to connect where. But it possibly only needs to be written down once.

@iMicknl iMicknl merged commit 2ce9bdd into iMicknl:v2 Jul 28, 2024
6 checks passed
@jamesmyatt jamesmyatt deleted the fix-docs branch September 23, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants