Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Proper external component for height sensor #84

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

jamesmyatt
Copy link
Contributor

@jamesmyatt jamesmyatt commented May 23, 2024

I think works as an external component. See #67. Can be tested by using the yaml config from the PR with:

external_components:
  source: github://jamesmyatt/[email protected]
  components: [ loctekmotion_desk_height ]

This is modelled on the code for https://esphome.io/components/sensor/a01nyub.html. Which can be found here: https://github.com/esphome/esphome/tree/dev/esphome/components/a01nyub.

@jamesmyatt jamesmyatt changed the title Fix external component for v2 [v2] Proper external component for height sensor May 23, 2024
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I will try this in the coming week(s).

DEVICE_CLASS_DISTANCE,
)

CODEOWNERS = ["@iMicknl"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmyatt, would you want to be added here as well? If you want to maintain this as well, or rather just a one-off contribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but it's probably easiest to leave it as it is for now. You're the only one with write access.

Copy link
Contributor Author

@jamesmyatt jamesmyatt Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iMicknl , I'm happy for you to make me a contributor/maintainer to this repo and add me to the CODEOWNERS here, if you want. I can help triage some of the issues.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a PR adding to the codeowners? I am now afk on holidays, but can arrange it in a week! :-)

packages/office-desk.yaml Show resolved Hide resolved
source: github://iMicknl/LoctekMotion_IoT@v2.1
components: [ loctekmotion_desk_height_sensor ]
source: github://iMicknl/LoctekMotion_IoT@v2.2
components: [ loctekmotion_desk_height ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a better name for the component, since "sensor" seemed redundant

Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@iMicknl iMicknl merged commit c33e438 into iMicknl:v2.1 Jun 1, 2024
@jamesmyatt jamesmyatt deleted the v2.2 branch June 4, 2024 08:43
@jamesmyatt
Copy link
Contributor Author

@iMicknl , the config in this PR assumes a "v2.2" branch in this repo. Can you add one or change the config to v2.1, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants