-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Proper external component for height sensor #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I will try this in the coming week(s).
DEVICE_CLASS_DISTANCE, | ||
) | ||
|
||
CODEOWNERS = ["@iMicknl"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesmyatt, would you want to be added here as well? If you want to maintain this as well, or rather just a one-off contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but it's probably easiest to leave it as it is for now. You're the only one with write access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iMicknl , I'm happy for you to make me a contributor/maintainer to this repo and add me to the CODEOWNERS here, if you want. I can help triage some of the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a PR adding to the codeowners? I am now afk on holidays, but can arrange it in a week! :-)
source: github://iMicknl/LoctekMotion_IoT@v2.1 | ||
components: [ loctekmotion_desk_height_sensor ] | ||
source: github://iMicknl/LoctekMotion_IoT@v2.2 | ||
components: [ loctekmotion_desk_height ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a better name for the component, since "sensor" seemed redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@iMicknl , the config in this PR assumes a "v2.2" branch in this repo. Can you add one or change the config to v2.1, please? |
I think works as an external component. See #67. Can be tested by using the yaml config from the PR with:
This is modelled on the code for https://esphome.io/components/sensor/a01nyub.html. Which can be found here: https://github.com/esphome/esphome/tree/dev/esphome/components/a01nyub.