Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Rails 6.1 #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JasonBarnabe
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Dec 22, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 7ebff27 on JasonBarnabe:rails-6.1-test into 333dc27 on iGEL:main.

@JasonBarnabe
Copy link
Author

JasonBarnabe commented Dec 22, 2020

Rubcop complains, unrelated to my changes, that:

lib/it/plain.rb:4:5: W: Lint/MissingSuper: Call super to initialize state of the parent class.
    def initialize(template = '%s') ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I'm not sure if Plain needs to inherit from Tag, but the parameters to initialize seem different so calling super doesn't make sense. I've just disabled this cop.

@JasonBarnabe
Copy link
Author

@iGEL Can you take a look at this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants