Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice and formatting of solidity registries #70

Closed

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Apr 22, 2024

No description provided.

zguesmi added 2 commits April 22, 2024 17:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@zguesmi zguesmi self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 98.95833% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (e37c9b8) to head (2d30b23).

Files with missing lines Patch % Lines
contracts/registries/Registry.sol 95.83% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           feature/format-module-delegates      #70      +/-   ##
===================================================================
- Coverage                            78.88%   78.75%   -0.13%     
===================================================================
  Files                                   34       34              
  Lines                                 1146     1144       -2     
  Branches                               216      237      +21     
===================================================================
- Hits                                   904      901       -3     
- Misses                                 242      243       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want in a later PR add import correctly ? like here

@zguesmi zguesmi closed this Feb 19, 2025
@zguesmi zguesmi deleted the feature/format-registries branch February 19, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants