-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will allow side alphabet list to work properly on android when the co… #36
Open
mag1492
wants to merge
2
commits into
i6mi6:master
Choose a base branch
from
mag1492:fix/dynamicFirstElementOffsetWithEmptySections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+659
−734
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,45 @@ | ||
'use strict'; | ||
|
||
import React, { | ||
Component, | ||
PropTypes | ||
} from 'react'; | ||
import ReactNative, { | ||
View | ||
} from 'react-native'; | ||
|
||
export default class CellWrapper extends Component { | ||
componentDidMount() { | ||
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId); | ||
} | ||
|
||
render() { | ||
const Cell = this.props.component; | ||
return ( | ||
<View ref='view'> | ||
<Cell {...this.props} /> | ||
</View> | ||
); | ||
} | ||
} | ||
|
||
CellWrapper.propTypes = { | ||
|
||
/** | ||
* The id of the section | ||
*/ | ||
sectionId: PropTypes.oneOfType([ | ||
PropTypes.number, | ||
PropTypes.string | ||
]), | ||
|
||
/** | ||
* A component to render for each cell | ||
*/ | ||
component: PropTypes.func.isRequired, | ||
|
||
/** | ||
* A function used to propagate the root nodes handle back to the parent | ||
*/ | ||
updateTag: PropTypes.func | ||
|
||
}; | ||
'use strict'; | ||
|
||
import React, { Component } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import ReactNative, { | ||
View | ||
} from 'react-native'; | ||
|
||
export default class CellWrapper extends Component { | ||
|
||
componentDidMount() { | ||
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId); | ||
} | ||
|
||
render() { | ||
var Cell = this.props.component; | ||
return ( | ||
<View ref='view'> | ||
<Cell {...this.props} /> | ||
</View> | ||
); | ||
} | ||
} | ||
|
||
CellWrapper.propTypes = { | ||
|
||
/** | ||
* The id of the section | ||
*/ | ||
sectionId: PropTypes.oneOfType([ | ||
PropTypes.number, | ||
PropTypes.string | ||
]), | ||
|
||
/** | ||
* A component to render for each cell | ||
*/ | ||
component: PropTypes.func.isRequired, | ||
|
||
/** | ||
* A function used to propagate the root nodes handle back to the parent | ||
*/ | ||
updateTag: PropTypes.func | ||
|
||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,69 +1,68 @@ | ||
'use strict'; | ||
|
||
import React, { | ||
Component, | ||
PropTypes | ||
} from 'react'; | ||
import ReactNative, { | ||
StyleSheet, | ||
View, | ||
Text, | ||
NativeModules | ||
} from 'react-native'; | ||
|
||
const { UIManager } = NativeModules; | ||
|
||
export default class SectionHeader extends Component { | ||
|
||
componentDidMount() { | ||
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId); | ||
} | ||
|
||
render() { | ||
const SectionComponent = this.props.component; | ||
const content = SectionComponent ? | ||
<SectionComponent {...this.props} /> : | ||
<Text>{this.props.title}</Text>; | ||
|
||
return ( | ||
<View ref="view"> | ||
{content} | ||
</View> | ||
); | ||
} | ||
} | ||
|
||
const styles = StyleSheet.create({ | ||
container: { | ||
backgroundColor:'#f8f8f8', | ||
borderTopWidth: 1, | ||
borderTopColor: '#ececec' | ||
}, | ||
text: { | ||
fontWeight: '700', | ||
paddingTop:2, | ||
paddingBottom:2, | ||
paddingLeft: 2 | ||
} | ||
}); | ||
|
||
SectionHeader.propTypes = { | ||
|
||
/** | ||
* The id of the section | ||
*/ | ||
sectionId: PropTypes.oneOfType([ | ||
PropTypes.number, | ||
PropTypes.string | ||
]), | ||
|
||
/** | ||
* A component to render for each section item | ||
*/ | ||
component: PropTypes.func, | ||
|
||
/** | ||
* A function used to propagate the root nodes handle back to the parent | ||
*/ | ||
updateTag: PropTypes.func | ||
}; | ||
'use strict'; | ||
|
||
import React, { Component } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import ReactNative, { | ||
StyleSheet, | ||
View, | ||
Text, | ||
NativeModules | ||
} from 'react-native'; | ||
|
||
const UIManager = NativeModules; | ||
|
||
export default class SectionHeader extends Component { | ||
|
||
componentDidMount() { | ||
this.props.updateTag && this.props.updateTag(ReactNative.findNodeHandle(this.refs.view), this.props.sectionId); | ||
} | ||
|
||
render() { | ||
var SectionComponent = this.props.component; | ||
var content = SectionComponent ? | ||
<SectionComponent {...this.props} /> : | ||
<Text style={styles.text}>{this.props.title}</Text>; | ||
|
||
return ( | ||
<View ref="view" style={styles.container}> | ||
{content} | ||
</View> | ||
); | ||
} | ||
} | ||
|
||
var styles = StyleSheet.create({ | ||
container: { | ||
backgroundColor:'#f8f8f8', | ||
borderTopWidth: 1, | ||
borderTopColor: '#ececec' | ||
}, | ||
text: { | ||
fontWeight: '700', | ||
paddingTop:2, | ||
paddingBottom:2, | ||
paddingLeft: 2 | ||
} | ||
}); | ||
|
||
SectionHeader.propTypes = { | ||
|
||
/** | ||
* The id of the section | ||
*/ | ||
sectionId: PropTypes.oneOfType([ | ||
PropTypes.number, | ||
PropTypes.string | ||
]), | ||
|
||
/** | ||
* A component to render for each section item | ||
*/ | ||
component: PropTypes.func, | ||
|
||
/** | ||
* A function used to propagate the root nodes handle back to the parent | ||
*/ | ||
updateTag: PropTypes.func | ||
|
||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete - UIManager not used in this file