Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read the TraceId from Header and propagate it #164

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lfdesousa
Copy link
Contributor

The goal of this PR is to add the capability to use interpret the W3C headers as specified here: https://www.w3.org/TR/trace-context/ and at the moment we dump them in the log, that according to the application.yml is sending them to the console.
Please note I might have added more than needed in the application.yml in particular regarding the health endpoints, if that is the case I will amend it.

@qligier
Copy link
Collaborator

qligier commented Jul 30, 2024

Hi @lfdesousa! Thank you for this PR.
There was recently in IPF a move from Brave to Micrometer: oehf/ipf@70d4cd7
Does it impact this implementation? Should we do the same?

@oliveregger
Copy link
Collaborator

@lfdesousa will update the PR

@lfdesousa
Copy link
Contributor Author

I did an update on this PR, I also updated something related with ITI67, in particular RouteBuilder, there was an exception when the Mag was starting, though I will need that to be reviewed.

@qligier
Copy link
Collaborator

qligier commented Aug 22, 2024

Is it ready for review, or have you planned other changes?

In the route builder, the custom indentation helps to see the underlying structure of the route. It was particularly helpful here because of all the branching happening in this route.

@lfdesousa
Copy link
Contributor Author

Let me just check the indentation and then it will be ready for review.

@lfdesousa
Copy link
Contributor Author

I updated the identitation in the Route Builder, it should be better now, other than that I do not have other stuff to add for now.

@qligier
Copy link
Collaborator

qligier commented Sep 6, 2024

I quickly implemented the manual forwarding of the header to other outgoing messages, to be tested during the Projectathon: 0ce2029
There is one feature missing in IPF, we can't set HTTP headers in FHIR responses yet: oehf/ipf#458. Otherwise, it should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants