Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of IDP renew transaction #151

Merged
merged 8 commits into from
Jun 21, 2024
Merged

implementation of IDP renew transaction #151

merged 8 commits into from
Jun 21, 2024

Conversation

Alexander-Kreutz
Copy link
Collaborator

No description provided.

@qligier
Copy link
Collaborator

qligier commented Jun 19, 2024

angular-oauth2-oidc uses the same URL for the token retrieval and the token refresh, simply changing the grant_type, and offers no possibility to change it.
I'm not sure if it's specified by OAuth2; in doubt, I merged both routes (/token and /renew).

When refreshing the token, we need to specify the IDP (/token/alias/hin); it's not needed for the token retrieval but is still supported (the alias is simply ignored). When the OAuth library uses the same URL, it has to be specified.

I still need to implement the support for all IDPs.

@qligier qligier requested review from oliveregger and removed request for qligier June 20, 2024 16:04
@qligier
Copy link
Collaborator

qligier commented Jun 20, 2024

I implemented the multi-IDP support in the renew and could test it with TrustID.
For me, the PR is ready to merge.

@qligier qligier merged commit 00b6a66 into master Jun 21, 2024
3 checks passed
@qligier qligier deleted the feature_idp_renew branch June 21, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants