Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade YoutubeExplode #44

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

jparkerweb
Copy link
Contributor

seems to fix random download issues being reported

Copy link
Owner

@i3arnon i3arnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@i3arnon i3arnon merged commit 15a5c11 into i3arnon:master Jan 9, 2020
@i3arnon i3arnon changed the title upgrade YoutubeExplode Upgrade YoutubeExplode Jan 9, 2020
@i3arnon
Copy link
Owner

i3arnon commented Jan 9, 2020

You can get the updated release here: https://github.com/i3arnon/YouCast/releases/tag/2.8.0

@gandadil
Copy link

gandadil commented Jan 9, 2020

The version 2.7.1 released by @jparkerweb is working but 2.8.0 released here is not working. I see that the .EXE file size is much bigger on 2.7.1 then 2.8.0. Maybe some library is not included on 2.8?

@jparkerweb
Copy link
Contributor Author

The version 2.7.1 released by @jparkerweb is working but 2.8.0 released here is not working. I see that the .EXE file size is much bigger on 2.7.1 then 2.8.0. Maybe some library is not included on 2.8?

Strange... I had to downgrade the version of a few other libraries to get it to compile on my machine, but that shouldn't have impacted the actual fix. The fix was to update the YoutubeExplode nuget package. I just tried v2.8 released today and it is working for the videos I have tested so far (including the ones I had issues with before).

@gandadil Please try again and make sure to run the new 2.8 version in a directory with no other files (meaning to older version that included a bunch of .dll's, etc...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants