hacky fix for fixing output screencopy #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean generally I don't see much wrong here, maybe just make a retry counter that counts to 3 and aborts if it keeps not working? It can be reset once a frame gets sent successfully |
|
Sure, I'll make those changes quickly |
|
After experimenting a bit I found out that 3 would be too low of a number as it sometimes requires more retries. I did 6 for now, seems to work fine (at least on my machine) |
vaxerski
reviewed
Aug 19, 2024
|
lgtm |
vaxerski
approved these changes
Aug 19, 2024
spikespaz
pushed a commit
to spikespaz-contrib/xdg-desktop-portal-hyprland
that referenced
this pull request
Oct 28, 2024
The line hyprwm#249 calls system bus by default, dbus will deny this request, then we need to call session bus instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very hacky fix to make screencopy continue capturing frames after
Out of bufferserror occurs.PR as requested in #247