ensure framebuffer textures are detached and deleted, avoid leaving framebuffers bound when not needed #9188
Conversation
its safe to do so but it adds a bunch of unnecessery lines in apitrace when tracing. if guard it and return early.
ensure bound buffers are unbound after use, also detach textures from framebuffer before deleting it otherwise it will become dangling and essentially leak.
|
Will be hard to test on nvidia. Some vram might stay reserved for HL with nvidia drivers if it is not needed. Starting some vram heavy app should take that memory from HL. |
Perhaps, was apitrace reporting leaks and i found post similar to these https://stackoverflow.com/a/19422828 even tho opengl manpages seems to suck explaining things like this |
without detaching textures before deleting them they become dangling in vram if my google skills are correct. so ensure we call glFramebufferTexture2D on the framebuffer before deleting it. and in good practice try to unbind the framebuffers where framebuffers have been bound after its usage. and dont call glDeleteProgram on a zero program, its safe to do so but fills apitrace up with unnecessery lines.