Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clang-format fix #9145

Merged
merged 3 commits into from
Jan 27, 2025
Merged

ci: clang-format fix #9145

merged 3 commits into from
Jan 27, 2025

Conversation

littleblack111
Copy link
Contributor

Describe your PR, what does it fix/add?

fix again, (see https://discord.com/channels/961691461554950145/1070436481912549497/1331967678763499580)

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

used the second method:

You can try switching to use pull_request_target as the event, which will cause the workflow to run in your branch context — the target of the PR itself. I think that will get the default GITHUB_TOKEN working, or you could optionally provide your own token as a secret on your repo and it will get picked up even if a fork triggered the run.

One minor caveat to pull_request_target that I've noticed is that it makes workflow development somewhat more difficult, since the workflow and action changes in an active PR won't be picked up. Not a huge issue, but worth being aware of.

Is it ready for merging, or does it need work?

yes

@littleblack111 littleblack111 changed the title Ci fix ci: clang-format fix Jan 23, 2025
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nukes c-f checks on main though, which also need to happen, just without any comments

@littleblack111
Copy link
Contributor Author

This nukes c-f checks on main though, which also need to happen, just without any comments

mb i forgot to read, however, i did found an action that can add comment to commit. or should i just let it fail

@vaxerski
Copy link
Member

Just fail it, no need to add a comment to a commit.

Also can you rebase so that ci doesnt fail

@littleblack111
Copy link
Contributor Author

done

@littleblack111
Copy link
Contributor Author

cc: @vaxerski

@vaxerski vaxerski merged commit cb7ed4f into hyprwm:main Jan 27, 2025
11 checks passed
@littleblack111 littleblack111 deleted the ci-fix branch January 28, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants