fix: make address parsing consistent between events and data commands #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also think this closes #86 as that won't be needed now that addresses are consistently formatted |
yavko
approved these changes
Aug 4, 2023
Yup |
Same 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85 actually created issues with data returned from data commands.
The issue stems from the fact that data commands are calling hyprctl with the
--jsonflag enabled. hyprctl returns addresses formatted as0xDEADBEEFfrom JSON, but does not do the same with regular output.Addresses in events are returned as
DEADBEEFinstead, so this causes inconsistencies in the data when it comes from data commands and when it comes from events.This PR addresses this issue by sticking with the
0xDEADBEEFformat, as that's the format dispatchers are expecting for window addresses. In every event listener where we are parsing window addresses, I simply prepended the matched address with0xin a helper function.