fix: updated getoption logic for Hyprland v0.36 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavko
requested changes
Apr 4, 2024
|
Also, I added simple tests for check this. Add they to repo or not? |
yavko
approved these changes
Apr 5, 2024
make new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Hyprland version (at this moment - 0.36) have changed the
getoptioncommand, where value can be either a str, an int or a float. So with old logic the Serde expects an int or a float (firstly integer), but there it doesn't exists.I marked these values as Option<T> and changed logic in parsing keyword.
I'm not sure about edge cases, so I'm open to another opinions.
Fixes issue #184 .