Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WorkspaceIdentifier(WithSpecial) variant for r prefix #158

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Add WorkspaceIdentifier(WithSpecial) variant for r prefix #158

merged 2 commits into from
Jan 27, 2024

Conversation

sij1nk
Copy link
Contributor

@sij1nk sij1nk commented Jan 27, 2024

This PR:

  • adds a RelativeMonitorIncludingEmpty variant for WorkspaceIdentifier(WithSpecial), which corresponds to the relative workspace address format with the r prefix

https://wiki.hyprland.org/Configuring/Dispatchers/#workspaces

20240127_16h37m50s_grim

  • fixes the doc comment for the RelativeMonitor variant

@sij1nk sij1nk marked this pull request as ready for review January 27, 2024 15:57
@sij1nk sij1nk changed the title Feat/relative monitor including empty Add WorkspaceIdentifier(WithSpecial) variant for r prefix Jan 27, 2024
yavko
yavko approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yavko yavko merged commit 54a0446 into hyprland-community:master Jan 27, 2024
3 checks passed
@sij1nk sij1nk deleted the feat/relative-monitor-including-empty branch January 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavko yavko yavko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sij1nk @yavko