Only upsert LMSUser on launches #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have access to User via request.user and that upsert LMS in practically every request. That is itself is a questionable design but for LMSUser we definitely only want to update it from the data from the LMS, not data we have forwarded back to use in API calls. Only upsert_lms_user in the two direct launches from the LMS, the "basic" launch and deep linking launches.
marcospri
force-pushed
the
fix-upsert-lms-user
branch
from
5ca43c5 to
b7679f2
Compare
marcospri
commented
Sep 13, 2024
| @@ -363,7 +363,7 @@ def get_lti_user(request) -> LTIUser | None: | |||
| if lti_user: | |||
| # Make a record of the user for analytics so we can map from the | |||
| # LTI users and the corresponding user in H | |||
| request.find_service(UserService).upsert_user(lti_user, request.lti_params) | |||
| request.find_service(UserService).upsert_user(lti_user) | |||
There was a problem hiding this comment.
Keep this method as it originally was
| return user | ||
|
|
||
| def _upsert_lms_user(self, user: User, lti_params: LTIParams) -> LMSUser: | ||
| def upsert_lms_user(self, user: User, lti_params: LTIParams) -> LMSUser: |
acelaya
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have access to User via request.user and that upserts
Userin practically every request.That is itself is a questionable design but for
LMSUserwe definitely only want to update it from the data from the LMS, not data we have forwarded back to use in API calls.Only upsert_lms_user in the two direct launches from the LMS, the "basic" launch and deep linking launches.
Testing
Launch a LTI1.1 assignment, nothing should change
Launch a LTI1.3 assignment, the new ID will be stored in the DB.
Check the ID in the table: