Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the LTI1.3 user_id in LMSUser #6671

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Store the LTI1.3 user_id in LMSUser #6671

merged 1 commit into from
Sep 11, 2024

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Sep 10, 2024

For:

In LTI1.1 launches we only get the LTI1.1 user_id. Conversely in "pure" LTI1.3 launches we only get the LTI1.3 ID.

However in updated LTI1.3 launches we get both versions, the LTI1.1 and LTI1.3 one. We have prefered the LTI1.1 for backwards compatibility, to keep the same identity in H.

While we do use now the LTI1.3 grading API we only do that in the context of a launch where we have all the parameters available to chose.

We need now to the LTI1.3 version in the DB to talk to the the grading API outside of the context of launch for the autograding feature.

Testing

from lms.tasks.roster import fetch_assignment_roster
fetch_assignment_roster.delay(assignment_id=121) # ID of an LTI1.3 assignment
 select display_name, lti_V13_user_id from lms_user;
          display_name          |           lti_v13_user_id            
--------------------------------+--------------------------------------
 Hypothesis 101 Student Student | 2b04173b-1f12-42ea-aa87-5dd0b6ef2473
 Hypothesis 101 Teacher Teacher | 3f25366d-ab34-4307-be21-3ea444559e82
 Leopoldd                       | 6798f121-8bb0-418c-ad9b-b61e400798f6
 eng+coursecopystudent          | 4a3d7f19-7eec-4231-813a-3542e8e8f476
 Test Student Student           | 2cd335e6-1061-40f5-a118-1c857cf7c7ab
(5 rows)

@marcospri marcospri requested a review from acelaya September 10, 2024 12:56
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and worked as described.

@marcospri marcospri force-pushed the lms-user-v13-id-model branch 2 times, most recently from 69242fb to 9454965 Compare September 11, 2024 08:11
Base automatically changed from lms-user-v13-id-model to main September 11, 2024 08:17
@marcospri marcospri merged commit 737cf16 into main Sep 11, 2024
9 checks passed
@marcospri marcospri deleted the lms-user-v13-id-code branch September 11, 2024 08:37
@marcospri marcospri mentioned this pull request Sep 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants