Improve type coverage for auto-grading #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Sep 4, 2024
| @@ -160,6 +161,10 @@ function PanelLabel({ | |||
| ); | |||
| } | |||
|
|
|||
| type DeepLinkingAPIData = Record<string, unknown> & { | |||
| auto_grading_config: APIAutoGradingConfig | null; | |||
| }; | |||
There was a problem hiding this comment.
For now I have only defined types for auto_grading_config, which is the most complex prop.
We can enhance this type later with the other known props.
acelaya
commented
Sep 4, 2024
| * If defined, it indicated this assignment was configured with auto grading | ||
| * enabled. | ||
| */ | ||
| auto_grading_config?: AutoGradingConfig; |
There was a problem hiding this comment.
This property will be returned only from the /api/dashboard/assignment/{assignment_id} endpoint.
The items from the metrics and filters lists will not include this prop.
@marcospri can you confirm my assumption is correct?
There was a problem hiding this comment.
The items from the metrics and filters lists will not include this prop.
Yes 👍
acelaya
force-pushed
the
type-safe-auto-grading
branch
2 times, most recently
from
90ea75f to
32f650d
Compare
robertknight
approved these changes
Sep 5, 2024
acelaya
force-pushed
the
type-safe-auto-grading
branch
from
32f650d to
a299fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some extra types around auto-grading, with the purpose of:
Both server/python types are equivalent, so we are reusing the same definition here.