Keep LMSCourse and LMSUser up to date on every launch #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
changed the title
21 tasks
marcospri
changed the title
marcospri
requested review from
acelaya and
seanh
and removed request for
acelaya
marcospri
changed the base branch from
main
to
fix-lms-course-membership-table
marcospri
force-pushed
the
upsert-lms-user-lms-course
branch
from
d3a7c9c to
03af337
Compare
seanh
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
This the revert-of-a-revert PR
I reverted #6588 due to a bug, fixed in this commit: d3a7c9c.
We should not try to upsert "copied_from_id" in the new table as the reference to the original courses might not yet exists in the DB. We can only do that once backfill the table.