Refactor get_assignments tests to exercise all parameters independently and combined #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
changed the title
marcospri
commented
Jul 9, 2024
|
|
||
| query = svc.get_assignments(**query_parameters) | ||
|
|
||
| if not query_parameters: |
There was a problem hiding this comment.
Improve the assert here, check it matches the assignment created in this test (assignment) + the other ones in the DB (with_assignment_noise).
marcospri
commented
Jul 9, 2024
| tool_consumer_instance_guid="noise_tool_consumer_instance_guid", | ||
| resource_link_id=assignment.resource_link_id, | ||
| ) | ||
| return [ |
There was a problem hiding this comment.
This fixture now not only creates the assignments but returns them. I reckon all fixtures should return the values they create even if not immediately used.
marcospri
force-pushed
the
api-filter-assignments-by-assignments
branch
from
21604e6 to
a05f95c
Compare
marcospri
force-pushed
the
api-filter-assignments-by-assignments
branch
from
a05f95c to
a678126
Compare
marcospri
force-pushed
the
get-assignments-test-refactor
branch
from
2ce6a89 to
9236174
Compare
marcospri
force-pushed
the
get-assignments-test-refactor
branch
from
9236174 to
0472e36
Compare
marcospri
merged commit 981aa5a
into
api-filter-assignments-by-assignments
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this would help detect issues like: #6429 (comment)