DTPOMERSER-1389 Update OS to runner mac-15, install swiftlinter and a…

…ddress lint issues (#151)
hyperwallet · Jan 30, 2025 · 68b1894 · 68b1894
1 parent b3f8408
commit 68b1894
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,8 +16,8 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: macos-12
-            xcode_version: 14.2
+          - os: macos-15
+            xcode_version: 16.2
             fastlane_task: unit_tests
 
     runs-on: ${{ matrix.os }}
@@ -47,8 +47,12 @@ jobs:
       - name: Run ${{ matrix.task_title }}
         run: fastlane ${{ matrix.fastlane_task }}
 
-      - name: Lint validation
+      - name: Install Lint
         run:
+          brew install swiftlint
+
+      - name: Lint validation
+        run: 
           swiftlint lint --strict --reporter json
 
       - name: Code Coverage [Build report]
@@ -74,4 +78,4 @@ jobs:
       - name: Post to Coveralls
         uses: coverallsapp/github-action@master
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/Tests/AnyCodableTests.swift b/Tests/AnyCodableTests.swift
@@ -20,8 +20,9 @@ class AnyCodableTests: XCTestCase {
 
         // Then
         XCTAssertNotNil(jsonBody)
-        let jsonBodyString = String(decoding: jsonBody, as: UTF8.self)
-        XCTAssertTrue(((jsonBodyString.contains("USD"))))
+        let jsonBodyString = String(bytes: jsonBody, encoding: .utf8)
+        XCTAssertNotNil(jsonBodyString)
+        XCTAssertTrue(((jsonBodyString!.contains("USD"))))
     }
 
     func testDecode() {

diff --git a/Tests/Helper/AuthenticationProviderMock.swift b/Tests/Helper/AuthenticationProviderMock.swift
@@ -20,8 +20,8 @@ class AuthenticationProviderMock: HyperwalletAuthenticationTokenProvider {
         error = nil
     }
 
-    func retrieveAuthenticationToken(completionHandler authenticationTokenHandler: @escaping
-        AuthenticationProviderMock.CompletionHandler) {
+    func retrieveAuthenticationToken(
+        completionHandler authenticationTokenHandler: @escaping AuthenticationProviderMock.CompletionHandler) {
         hasRequestedClientToken = true
         authenticationTokenHandler(authorizationData, error)
     }

diff --git a/Tests/TransactionTypeTests.swift b/Tests/TransactionTypeTests.swift
@@ -116,9 +116,9 @@ class TransactionTypeTests: XCTestCase {
             if httpMethod == .get {
                 XCTAssertNil(urlRequest.httpBody, "The HTTP body should be nil")
             } else {
-                let httpBody = String(decoding: urlRequest.httpBody!, as: UTF8.self)
+                let httpBody = String(bytes: urlRequest.httpBody!, encoding: .utf8)
                 let payloadData = try JSONEncoder().encode(payload)
-                let payloadString = String(decoding: payloadData, as: UTF8.self)
+                let payloadString = String(bytes: payloadData, encoding: .utf8)
                 XCTAssertEqual(httpBody, payloadString, "The HTTP body should be equals to payload")
             }
 
@@ -165,7 +165,7 @@ class TransactionTypeTests: XCTestCase {
             if httpMethod == .get {
                 XCTAssertNil(urlRequest.httpBody, "The HTTP body should be nil")
             } else {
-                let query = String(decoding: urlRequest.httpBody!, as: UTF8.self)
+                let query = String(bytes: urlRequest.httpBody!, encoding: .utf8)
                 let payloadString = payload.toGraphQl(userToken: configuration.userToken)
                 XCTAssertEqual(query, payloadString, "The HTTP body should be equals to payload")
             }