second submit 0.10.0

hypertidy · Jun 14, 2024 · 84de214 · 84de214
1 parent 8d3f249
commit 84de214
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # vapour 0.10.0
 
+* Fixed leaks from valgrind, thanks CRAN. 
+
 * Cleaned up a number of address sanitize issues and segfaults, thanks to CRAN. 
 
 * Old warper code is removed, now uses 'gdal_raster_' from warpgeneral. 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,17 +1,14 @@
 ## vapour 0.10.0
 
-To fix errors on CRAN. 
+Second submission. Fixed memory leaks detected with valgrind. 
 
-vapour is now passing ubuntu-clang and clang-asan via rhub and not segfaulting on the systems reported on 
-CRAN results. 
-
-There are valgrind messages but I think these are internal to GDAL from CSLAddString, CPLRealloc, GDALInfo and others and I will investigate further. 
+Thanks!
 
 ## Test environments
 
 * win-builder (devel)
 * macos on rhub
-* Linux ubuntu-clang, clang-asan on rhub. 
+* Linux ubuntu-clang, clang-asan, and valgrind on rhub. 
 
 ## R CMD check results