-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pixelwise EDS live time / real time into digital micrograph file reader #124
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 85.00% 84.61% -0.39%
==========================================
Files 73 73
Lines 9054 9119 +65
Branches 2049 2060 +11
==========================================
+ Hits 7696 7716 +20
- Misses 892 936 +44
- Partials 466 467 +1
☔ View full report in Codecov by Sentry. |
I am really interested into outcomes of this PR. During EMAS workshop I had an opportunity to talk with few different engineers from different vendors of EDS. Different vendors have different approaches to the same problem. In case of Bruker, live time is encoded inside EDS spectra (known as 0eV peak). Just as a funny thing, from one of other vendor representative when discussing how dead times are handled in other vendor EDS, 0eV peak was commented by one as the most brilliant way, and other as most ******-way (Both engineers was not from Bruker, just to clarify). So for some time I was wondering if live_time should be returned as static array, or as a function, or property (which would trigger catched getter)... @nem1234 what you would suggest? Also how to deal with fact that Hyperspy expects a single value instead of array as live time? |
Umm..... We want to compare the quantity of elements between EDS and EELS. And in our case, (may be depend on the combination of TEM and EDS), overall live-time is not recorded into digital micrograph tags. In my opinion, My current problems....
Hyperspy related problems:
|
In definition of EDS metadata,
|
if _notes is None: | ||
_notes = "" | ||
_num_cycle = _om_si.get("Number of cycles") | ||
_pi = _om_si.get("Pixel iterator") |
Check notice
Code scanning / CodeQL
Unused local variable
if _pt * 1.1 < _rta: | ||
_logger.warning("Pixel time ({:.1f} ms) / EDS real time ({:.1f} ms) mismatch".format(_pt * 1000, _rta * 1000)) | ||
if _num_cycle != 1: | ||
_warn = "Part of pixel-wise real-time/live-time data was lost when number of cycles != 1" |
Check notice
Code scanning / CodeQL
Unused local variable
Draft
Not ready to merge
Description of the change
ToDo:
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature