Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-498: Shared local logging #682

Merged
merged 15 commits into from
Sep 29, 2023
Merged

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Sep 26, 2023

YouTrack Issues:
ALTAPPS-498

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Add multiplatform logger Kermit
  • Add LoggerCompoment to user predefined logger in the app
  • Add SentryLogWriter to write logs into Sentry
  • Add StateReducer.wrapWithLogger() extension to log state and actions procured by reducer

@XanderZhu XanderZhu added the shared Shared module task label Sep 26, 2023
@XanderZhu XanderZhu added this to the 1.36 milestone Sep 26, 2023
@XanderZhu XanderZhu self-assigned this Sep 26, 2023
@XanderZhu XanderZhu requested review from vladkash and ivan-magda and removed request for ivan-magda September 26, 2023 13:09
@XanderZhu XanderZhu marked this pull request as ready for review September 26, 2023 13:09
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Sep 27, 2023
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Sep 28, 2023
@github-actions github-actions bot added ios iOS module task android Android module task labels Sep 28, 2023
@XanderZhu
Copy link
Contributor Author

@vladkash
Do you have any comments on this issue?

@ivan-magda ivan-magda added the ready to pull Pull Request is ready to merge label Sep 29, 2023
@XanderZhu XanderZhu merged commit 59fe8f4 into develop Sep 29, 2023
11 checks passed
@XanderZhu XanderZhu deleted the feature/ALTAPPS-498/Local_logging branch September 29, 2023 11:10
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Sep 29, 2023
@vladkash
Copy link
Contributor

vladkash commented Oct 1, 2023

@XanderZhu no, I don't have them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants