-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALTAPPS-949: iOS make code editor an active input #677
Merged
ivan-magda
merged 20 commits into
develop
from
feature/ALTAPPS-949/ios_make_code_editor_active
Oct 2, 2023
Merged
ALTAPPS-949: iOS make code editor an active input #677
ivan-magda
merged 20 commits into
develop
from
feature/ALTAPPS-949/ios_make_code_editor_active
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
shared
Shared module task
ios
iOS module task
android
Android module task
labels
Sep 25, 2023
ivan-magda
force-pushed
the
feature/ALTAPPS-949/ios_make_code_editor_active
branch
from
September 27, 2023 11:51
38f124a
to
3bd2a9e
Compare
ivan-magda
changed the title
ALTAPPS-949: iOS make code editor active
ALTAPPS-949: iOS make code editor an active input
Sep 27, 2023
@XanderZhu here I removed problems limits state, updated strings, and added analytic events |
…9/ios_make_code_editor_active
vladkash
approved these changes
Oct 1, 2023
* ``` | ||
* @see HyperskillAnalyticEvent | ||
*/ | ||
class StepQuizFullScreenCodeEditorClickedCodeDetailsHyperskillAnalyticEvent( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's better to use name StepQuizFullScreenCodeEditorClickedInputOutputInfoHyperskillAnalyticEvent
to match event's target
ivan-magda
removed
awaiting review
Pull Request is awaiting code reviews
ready to pull
Pull Request is ready to merge
labels
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-949
Checklist
Before Code Review:
Description