Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-949: iOS make code editor an active input #677

Merged
merged 20 commits into from
Oct 2, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Sep 25, 2023

YouTrack Issues:
#ALTAPPS-949

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Updates appearance of the code-related problems (code, SQL, pycharm)
  2. The code editor now an active input with auto-growing behavior on text changes
  3. Removes limits UI
  4. Logs missing analytic events

@ivan-magda ivan-magda added this to the 1.36 milestone Sep 25, 2023
@ivan-magda ivan-magda self-assigned this Sep 25, 2023
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Sep 25, 2023
@ivan-magda ivan-magda force-pushed the feature/ALTAPPS-949/ios_make_code_editor_active branch from 38f124a to 3bd2a9e Compare September 27, 2023 11:51
@ivan-magda ivan-magda changed the title ALTAPPS-949: iOS make code editor active ALTAPPS-949: iOS make code editor an active input Sep 27, 2023
@ivan-magda ivan-magda marked this pull request as ready for review September 27, 2023 14:29
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Sep 27, 2023
@ivan-magda
Copy link
Member Author

@XanderZhu here I removed problems limits state, updated strings, and added analytic events

* ```
* @see HyperskillAnalyticEvent
*/
class StepQuizFullScreenCodeEditorClickedCodeDetailsHyperskillAnalyticEvent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's better to use name StepQuizFullScreenCodeEditorClickedInputOutputInfoHyperskillAnalyticEvent to match event's target

@vladkash vladkash added the ready to pull Pull Request is ready to merge label Oct 1, 2023
@ivan-magda ivan-magda removed awaiting review Pull Request is awaiting code reviews ready to pull Pull Request is ready to merge labels Oct 2, 2023
@ivan-magda ivan-magda merged commit 8bc7ecb into develop Oct 2, 2023
11 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-949/ios_make_code_editor_active branch October 2, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants