Don't fail auth flow if the url doesn't contain the code query parameter

hyperskill · Jul 25, 2023 · 5625cf3 · 5625cf3
1 parent ee784d2
commit 5625cf3
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/...p/src/main/java/org/hyperskill/app/android/auth/view/ui/widget/AuthSocialWebViewClient.kt b/...p/src/main/java/org/hyperskill/app/android/auth/view/ui/widget/AuthSocialWebViewClient.kt
@@ -26,26 +26,23 @@ class AuthSocialWebViewClient(
         request?.url?.let { url ->
             val urlString = url.toString()
             if (urlString.startsWith("https://${networkEndpointConfigInfo.host}/oauth?")) {
-                val message = try {
-                    val codeQueryParameter = url.getQueryParameter(CodeParameter)
-                    if (codeQueryParameter != null) {
-                        AuthSocialWebViewFeature.Message.AuthCodeSuccess(
-                            codeQueryParameter,
-                            socialAuthProvider
+                try {
+                    url.getQueryParameter(CodeParameter)?.let { codeQueryParameter ->
+                        onNewMessage(
+                            AuthSocialWebViewFeature.Message.AuthCodeSuccess(
+                                codeQueryParameter,
+                                socialAuthProvider
+                            )
                         )
-                    } else {
+                    }
+                } catch (e: UnsupportedOperationException) {
+                    onNewMessage(
                         AuthSocialWebViewFeature.Message.AuthCodeFailure(
                             socialError = AuthSocialError.CONNECTION_PROBLEM,
-                            originalError = IllegalStateException("No code query parameter in url")
+                            originalError = e
                         )
-                    }
-                } catch (e: UnsupportedOperationException) {
-                    AuthSocialWebViewFeature.Message.AuthCodeFailure(
-                        socialError = AuthSocialError.CONNECTION_PROBLEM,
-                        originalError = e
                     )
                 }
-                onNewMessage(message)
             }
         }
         return false