Fix review issues

androidHyperskillApp/src/main/java/org/hyperskill/app/android/sentry/domain/model/manager/SentryManagerImpl.kt

@@ -1,7 +1,6 @@
 package org.hyperskill.app.android.sentry.domain.model.manager
 
 import io.sentry.Sentry
-import io.sentry.SentryLevel
 import io.sentry.SpanStatus
 import io.sentry.android.core.SentryAndroid
 import io.sentry.android.fragment.FragmentLifecycleIntegration
@@ -18,7 +17,10 @@ import org.hyperskill.app.sentry.domain.model.manager.SentryManager
 import org.hyperskill.app.sentry.domain.model.transaction.HyperskillSentryTransaction
 import org.hyperskill.app.sentry.domain.model.transaction.HyperskillSentryTransactionKeyValues
 
-class SentryManagerImpl(private val buildKonfig: BuildKonfig) : SentryManager {
+class SentryManagerImpl(
+    private val buildKonfig: BuildKonfig,
+    private val minLogLevel: HyperskillSentryLevel = HyperskillSentryLevel.min(buildKonfig.buildVariant)
+) : SentryManager {
     private val currentTransactionsMap = mutableMapOf<Int, PlatformHyperskillSentryTransaction>()
 
     override fun setup() {
@@ -35,10 +37,10 @@ class SentryManagerImpl(private val buildKonfig: BuildKonfig) : SentryManager {
                     enableAutoFragmentLifecycleTracing = true
                 )
             )
+            options.setDiagnosticLevel(minLogLevel.toSentryLevel())
 
             if (BuildConfig.DEBUG) {
                 options.setDebug(true)
-                options.setDiagnosticLevel(SentryLevel.WARNING)
                 options.tracesSampleRate = 1.0
             } else {
                 options.setDebug(false)

iosHyperskillApp/iosHyperskillApp/Sources/Systems/Sentry/SentryManager.swift

@@ -22,11 +22,12 @@ final class SentryManager: shared.SentryManager {
 
             #if DEBUG
             options.debug = true
-            options.diagnosticLevel = .info
+            options.diagnosticLevel = .debug
 
             options.tracesSampleRate = 1
             #else
             options.tracesSampleRate = 0.3
+            options.diagnosticLevel = .info
             #endif
 
             // HTTP Client Errors

shared/src/commonMain/kotlin/org/hyperskill/app/auth/injection/AuthSocialComponent.kt

@@ -1,16 +1,16 @@
 package org.hyperskill.app.auth.injection
 
-import org.hyperskill.app.auth.presentation.AuthSocialFeature.Action
-import org.hyperskill.app.auth.presentation.AuthSocialFeature.Message
-import org.hyperskill.app.auth.presentation.AuthSocialFeature.State
+import org.hyperskill.app.auth.presentation.AuthSocialFeature.Action as AuthSocialAction
+import org.hyperskill.app.auth.presentation.AuthSocialFeature.Message as AuthSocialMessage
+import org.hyperskill.app.auth.presentation.AuthSocialFeature.State as AuthSocialState
+import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.Action as AuthSocialWebViewAction
+import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.Message as AuthSocialWebViewMessage
+import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.State as AuthSocialWebViewState
 import org.hyperskill.app.auth.view.mapper.AuthSocialErrorMapper
 import ru.nobird.app.presentation.redux.feature.Feature
-import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.Action as WebViewAction
-import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.Message as WebViewMessage
-import org.hyperskill.app.auth.presentation.AuthSocialWebViewFeature.State as WebViewState
 
 interface AuthSocialComponent {
-    val authSocialFeature: Feature<State, Message, Action>
+    val authSocialFeature: Feature<AuthSocialState, AuthSocialMessage, AuthSocialAction>
     val authSocialErrorMapper: AuthSocialErrorMapper
-    val authSocialWebViewFeature: Feature<WebViewState, WebViewMessage, WebViewAction>
+    val authSocialWebViewFeature: Feature<AuthSocialWebViewState, AuthSocialWebViewMessage, AuthSocialWebViewAction>
 }

shared/src/commonMain/kotlin/org/hyperskill/app/auth/injection/AuthSocialWebViewFeatureBuilder.kt

@@ -15,6 +15,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object AuthSocialWebViewFeatureBuilder {
     private const val LOG_TAG = "AuthSocialWebViewFeature"
+
     fun build(
         logger: Logger,
         buildVariant: BuildVariant

shared/src/commonMain/kotlin/org/hyperskill/app/debug/injection/DebugFeatureBuilder.kt

@@ -17,6 +17,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object DebugFeatureBuilder {
     private const val LOG_TAG = "DebugFeature"
+
     fun build(
         debugInteractor: DebugInteractor,
         appInteractor: AppInteractor,

shared/src/commonMain/kotlin/org/hyperskill/app/home/injection/HomeFeatureBuilder.kt

@@ -32,7 +32,6 @@ import ru.nobird.app.presentation.redux.feature.Feature
 import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object HomeFeatureBuilder {
-
     private const val LOG_TAG = "HomeFeature"
 
     fun build(

shared/src/commonMain/kotlin/org/hyperskill/app/logging/SentryLogWriter.kt

@@ -30,8 +30,7 @@ class SentryLogWriter(
             Severity.Info -> sentryInteractor.captureMessage(formattedMessage, HyperskillSentryLevel.INFO)
             Severity.Warn -> sentryInteractor.captureMessage(formattedMessage, HyperskillSentryLevel.WARNING)
             Severity.Error -> sentryInteractor.captureMessage(formattedMessage, HyperskillSentryLevel.ERROR)
-            Severity.Debug -> sentryInteractor.captureMessage(formattedMessage, HyperskillSentryLevel.DEBUG)
-            Severity.Verbose, Severity.Assert -> {
+            Severity.Debug, Severity.Verbose, Severity.Assert -> {
                 // no op
             }
         }

shared/src/commonMain/kotlin/org/hyperskill/app/logging/inject/LoggerBuilder.kt

@@ -10,14 +10,15 @@ import org.hyperskill.app.sentry.domain.interactor.SentryInteractor
 
 object LoggerBuilder {
     private const val LOG_TAG = "HYPERSKILL_APP"
+
     fun build(
         buildVariant: BuildVariant,
         sentryInteractor: SentryInteractor
     ): Logger =
         Logger(
             config = StaticConfig(
-                logWriterList = listOf(
-                    platformLogWriter(),
+                logWriterList = listOfNotNull(
+                    if (buildVariant == BuildVariant.RELEASE) null else platformLogWriter(),
                     SentryLogWriter(sentryInteractor)
                 ),
                 minSeverity = if (buildVariant == BuildVariant.RELEASE) {

shared/src/commonMain/kotlin/org/hyperskill/app/logging/inject/LoggerComponentImpl.kt

@@ -3,10 +3,10 @@ package org.hyperskill.app.logging.inject
 import co.touchlab.kermit.Logger
 import org.hyperskill.app.core.injection.AppGraph
 
-class LoggerComponentImpl(private val appGraph: AppGraph) : LoggerComponent {
-    override val logger: Logger
-        get() = LoggerBuilder.build(
-            appGraph.commonComponent.buildKonfig.buildVariant,
-            appGraph.sentryComponent.sentryInteractor
-        )
+class LoggerComponentImpl(appGraph: AppGraph) : LoggerComponent {
+
+    override val logger: Logger = LoggerBuilder.build(
+        appGraph.commonComponent.buildKonfig.buildVariant,
+        appGraph.sentryComponent.sentryInteractor
+    )
 }

shared/src/commonMain/kotlin/org/hyperskill/app/logging/presentation/WrapWithLogger.kt

@@ -52,7 +52,7 @@ private class LoggableStateReducer<State, Message, Action>(
             if (initialState == newState) {
                 "reduce(\nmessage=$message,\nstate=$initialState\n)\nActions=$actions\nNew state = SAME"
             } else {
-                "reduce(\nmessage=$message,\nstate=PREVIOUS\n)\nActions=$actions\nNew state = $newState"
+                "reduce(\nmessage=$message,\nstate=$initialState\n)\nActions=$actions\nNew state = $newState"
             }
         }
     }

shared/src/commonMain/kotlin/org/hyperskill/app/main/injection/AppFeatureBuilder.kt

@@ -30,6 +30,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object AppFeatureBuilder {
     private const val LOG_TAG = "AppFeature"
+
     fun build(
         initialState: State?,
         appInteractor: AppInteractor,

shared/src/commonMain/kotlin/org/hyperskill/app/notifications_onboarding/injection/NotificationsOnboardingFeatureBuilder.kt

@@ -17,6 +17,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object NotificationsOnboardingFeatureBuilder {
     private const val LOG_TAG = "NotificationsOnboardingFeature"
+
     fun build(
         analyticInteractor: AnalyticInteractor,
         notificationInteractor: NotificationInteractor,

shared/src/commonMain/kotlin/org/hyperskill/app/onboarding/injection/OnboardingFeatureBuilder.kt

@@ -18,6 +18,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object OnboardingFeatureBuilder {
     private const val LOG_TAG = "OnboardingFeature"
+
     fun build(
         onboardingInteractor: OnboardingInteractor,
         currentProfileStateRepository: CurrentProfileStateRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/profile/injection/ProfileFeatureBuilder.kt

@@ -25,7 +25,8 @@ import ru.nobird.app.presentation.redux.feature.Feature
 import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object ProfileFeatureBuilder {
-    private const val LOG_TAG = "ProfileFeatureBuilder"
+    private const val LOG_TAG = "ProfileFeature"
+
     fun build(
         profileInteractor: ProfileInteractor,
         currentProfileStateRepository: CurrentProfileStateRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/profile_settings/injection/ProfileSettingsFeatureBuilder.kt

@@ -24,6 +24,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object ProfileSettingsFeatureBuilder {
     private const val LOG_TAG = "ProfileSettingsFeature"
+
     fun build(
         profileSettingsInteractor: ProfileSettingsInteractor,
         currentProfileStateRepository: CurrentProfileStateRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/progress_screen/injection/ProgressScreenFeatureBuilder.kt

@@ -23,6 +23,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object ProgressScreenFeatureBuilder {
     private const val LOG_TAG = "ProgressScreenFeature"
+
     fun build(
         currentStudyPlanStateRepository: CurrentStudyPlanStateRepository,
         currentProfileStateRepository: CurrentProfileStateRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/project_selection/details/injection/ProjectSelectionDetailsFeatureBuilder.kt

@@ -30,6 +30,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object ProjectSelectionDetailsFeatureBuilder {
     private const val LOG_TAG = "ProjectSelectionDetailsFeature"
+
     fun build(
         params: ProjectSelectionDetailsParams,
         trackRepository: TrackRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/project_selection/list/injection/ProjectSelectionListFeatureBuilder.kt

@@ -25,6 +25,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object ProjectSelectionListFeatureBuilder {
     private const val LOG_TAG = "ProjectSelectionListFeature"
+
     fun build(
         params: ProjectSelectionListParams,
         trackRepository: TrackRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/sentry/domain/model/level/HyperskillSentryLevel.kt

@@ -1,5 +1,7 @@
 package org.hyperskill.app.sentry.domain.model.level
 
+import org.hyperskill.app.core.domain.BuildVariant
+
 /**
  * Represents the severity level of an event.
  *
@@ -11,5 +13,14 @@ enum class HyperskillSentryLevel {
     INFO,
     WARNING,
     ERROR,
-    FATAL
+    FATAL;
+
+    companion object {
+        fun min(buildVariant: BuildVariant): HyperskillSentryLevel =
+            if (buildVariant == BuildVariant.RELEASE) {
+                INFO
+            } else {
+                DEBUG
+            }
+    }
 }

shared/src/commonMain/kotlin/org/hyperskill/app/stage_implement/injection/StageImplementFeatureBuilder.kt

@@ -23,6 +23,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object StageImplementFeatureBuilder {
     private const val LOG_TAG = "StageImplementFeature"
+
     fun build(
         projectId: Long,
         stageId: Long,

shared/src/commonMain/kotlin/org/hyperskill/app/step/injection/StepFeatureBuilder.kt

@@ -24,6 +24,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object StepFeatureBuilder {
     private const val LOG_TAG = "StepFeature"
+
     fun build(
         stepRoute: StepRoute,
         stepInteractor: StepInteractor,

shared/src/commonMain/kotlin/org/hyperskill/app/step_quiz/injection/StepQuizFeatureBuilder.kt

@@ -27,6 +27,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object StepQuizFeatureBuilder {
     private const val LOG_TAG = "StepQuizFeature"
+
     fun build(
         stepRoute: StepRoute,
         problemsLimitReducer: ProblemsLimitReducer,

shared/src/commonMain/kotlin/org/hyperskill/app/step_quiz_hints/injection/StepQuizHintsFeatureBuilder.kt

@@ -24,6 +24,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object StepQuizHintsFeatureBuilder {
     private const val LOG_TAG = "StepQuizHintsFeature"
+
     fun build(
         stepRoute: StepRoute,
         stepQuizHintsInteractor: StepQuizHintsInteractor,

shared/src/commonMain/kotlin/org/hyperskill/app/study_plan/screen/injection/StudyPlanScreenFeatureBuilder.kt

@@ -30,6 +30,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object StudyPlanScreenFeatureBuilder {
     private const val LOG_TAG = "StudyPlanScreenFeature"
+
     fun build(
         analyticInteractor: AnalyticInteractor,
         toolbarReducer: GamificationToolbarReducer,

shared/src/commonMain/kotlin/org/hyperskill/app/topics_repetitions/injection/TopicsRepetitionsFeatureBuilder.kt

@@ -21,6 +21,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object TopicsRepetitionsFeatureBuilder {
     private const val LOG_TAG = "TopicsRepetitionsFeature"
+
     fun build(
         topicsRepetitionsInteractor: TopicsRepetitionsInteractor,
         currentProfileStateRepository: CurrentProfileStateRepository,

shared/src/commonMain/kotlin/org/hyperskill/app/track_selection/details/injection/TrackSelectionDetailsFeatureBuilder.kt

@@ -26,6 +26,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 object TrackSelectionDetailsFeatureBuilder {
     private const val LOG_TAG = "TrackSelectionDetailsFeature"
+
     fun build(
         params: TrackSelectionDetailsParams,
         resourceProvider: ResourceProvider,

shared/src/commonMain/kotlin/org/hyperskill/app/track_selection/list/injection/TrackSelectionListFeatureBuilder.kt

@@ -22,6 +22,7 @@ import ru.nobird.app.presentation.redux.feature.ReduxFeature
 
 internal object TrackSelectionListFeatureBuilder {
     private const val LOG_TAG = "TrackSelectionListFeature"
+
     fun build(
         params: TrackSelectionListParams,
         analyticInteractor: AnalyticInteractor,