Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal predicate for string namespaces #9282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add internal predicate for string namespaces #9282

wants to merge 1 commit into from

Conversation

mangalaman93
Copy link
Member

This PR adds two internal predicates needed for supporting namespaces with string names. We are creating a separate PR so that we can take this PR as model PR for adding more internal predicate in future.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on
    docs repo staged and linked here

@mangalaman93 mangalaman93 requested a review from a team as a code owner January 21, 2025 05:41
@github-actions github-actions bot added area/schema Issues related to the schema language and capabilities. area/core internal mechanisms go Pull requests that update Go code labels Jan 21, 2025
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 21, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@github-actions github-actions bot added area/testing Testing related issues area/enterprise Related to proprietary features area/integrations Related to integrations with other projects. area/enterprise/acl Related to Access Control Lists labels Jan 21, 2025
@mangalaman93 mangalaman93 force-pushed the aman/internal branch 2 times, most recently from ffed294 to 753bc7b Compare January 21, 2025 11:01
ryanfoxtyler
ryanfoxtyler reviewed Jan 21, 2025
View reviewed changes
.vscode/settings.json
"trunk.autoInit": false
"trunk.autoInit": false,
"[go]": {
"editor.defaultFormatter": "golang.go"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will remove some of Trunk's capabilities and shouldn't be necessary...are you seeing any issues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In local, it slows down saving files. Sometimes it even got stuck when my internet was slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanfoxtyler ryanfoxtyler ryanfoxtyler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/integrations Related to integrations with other projects. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangalaman93 @ryanfoxtyler