Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(debug): Close file correctly before exiting on error #9076

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

gcxml
Copy link
Contributor

@gcxml gcxml commented Apr 18, 2024

Improving on #9070. A file must be closed if the function exits on an error.

@gcxml gcxml requested a review from a team as a code owner April 18, 2024 20:16
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dgraph-bot dgraph-bot added the go Pull requests that update Go code label Apr 18, 2024
@gcxml gcxml requested a review from harshil-goel April 18, 2024 20:36
@gcxml gcxml changed the title Improving on pr-9070 Fix(debug): Close file correctly before exiting on error Apr 22, 2024
@gcxml gcxml merged commit 8563a54 into main Apr 22, 2024
12 checks passed
@gcxml gcxml deleted the pr-9070 branch April 22, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

4 participants