-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(dql): Split mutation test (#20)
Description: Splits apart the mutation_test.go in dgraph/worker into unit tests vs. integration tests. The purpose is to allow for more effective local tests.
- Loading branch information
1 parent
3754e87
commit d46ac28
Showing
2 changed files
with
162 additions
and
136 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| /* | ||
| * Copyright 2016-2023 Dgraph Labs, Inc. and Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package worker | ||
|
|
||
| import ( | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/dgraph-io/dgraph/protos/pb" | ||
| "github.com/dgraph-io/dgraph/types" | ||
| "github.com/dgraph-io/dgraph/x" | ||
| ) | ||
|
|
||
| func TestConvertEdgeType(t *testing.T) { | ||
| var testEdges = []struct { | ||
| input *pb.DirectedEdge | ||
| to types.TypeID | ||
| expectErr bool | ||
| output *pb.DirectedEdge | ||
| }{ | ||
| { | ||
| input: &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.GalaxyAttr("name"), | ||
| }, | ||
| to: types.StringID, | ||
| expectErr: false, | ||
| output: &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.GalaxyAttr("name"), | ||
| ValueType: 9, | ||
| }, | ||
| }, | ||
| { | ||
| input: &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.NamespaceAttr(0xf2, "name"), | ||
| Op: pb.DirectedEdge_DEL, | ||
| }, | ||
| to: types.StringID, | ||
| expectErr: false, | ||
| output: &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.NamespaceAttr(0xf2, "name"), | ||
| Op: pb.DirectedEdge_DEL, | ||
| ValueType: 9, | ||
| }, | ||
| }, | ||
| { | ||
| input: &pb.DirectedEdge{ | ||
| ValueId: 123, | ||
| Attr: x.GalaxyAttr("name"), | ||
| }, | ||
| to: types.StringID, | ||
| expectErr: true, | ||
| }, | ||
| { | ||
| input: &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.GalaxyAttr("name"), | ||
| }, | ||
| to: types.UidID, | ||
| expectErr: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, testEdge := range testEdges { | ||
| err := ValidateAndConvert(testEdge.input, | ||
| &pb.SchemaUpdate{ | ||
| ValueType: pb.Posting_ValType(testEdge.to), | ||
| }) | ||
| if testEdge.expectErr { | ||
| require.Error(t, err) | ||
| } else { | ||
| require.NoError(t, err) | ||
| require.True(t, reflect.DeepEqual(testEdge.input, testEdge.output)) | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| func TestValidateEdgeTypeError(t *testing.T) { | ||
| edge := &pb.DirectedEdge{ | ||
| Value: []byte("set edge"), | ||
| Attr: x.GalaxyAttr("name"), | ||
| } | ||
|
|
||
| err := ValidateAndConvert(edge, | ||
| &pb.SchemaUpdate{ | ||
| ValueType: pb.Posting_ValType(types.DateTimeID), | ||
| }) | ||
| require.Error(t, err) | ||
| } | ||
|
|
||
| func TestTypeSanityCheck(t *testing.T) { | ||
| // Empty field name check. | ||
| typeDef := &pb.TypeUpdate{ | ||
| Fields: []*pb.SchemaUpdate{ | ||
| { | ||
| Predicate: x.GalaxyAttr(""), | ||
| }, | ||
| }, | ||
| } | ||
| err := typeSanityCheck(typeDef) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "Field in type definition must have a name") | ||
|
|
||
| // Object type without object name. | ||
| typeDef = &pb.TypeUpdate{ | ||
| Fields: []*pb.SchemaUpdate{ | ||
| { | ||
| Predicate: x.GalaxyAttr("name"), | ||
| ValueType: pb.Posting_OBJECT, | ||
| }, | ||
| }, | ||
| } | ||
| err = typeSanityCheck(typeDef) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "Field with value type OBJECT must specify the name") | ||
|
|
||
| // Field with directive. | ||
| typeDef = &pb.TypeUpdate{ | ||
| Fields: []*pb.SchemaUpdate{ | ||
| { | ||
| Predicate: x.GalaxyAttr("name"), | ||
| Directive: pb.SchemaUpdate_REVERSE, | ||
| }, | ||
| }, | ||
| } | ||
| err = typeSanityCheck(typeDef) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "Field in type definition cannot have a directive") | ||
|
|
||
| // Field with tokenizer. | ||
| typeDef = &pb.TypeUpdate{ | ||
| Fields: []*pb.SchemaUpdate{ | ||
| { | ||
| Predicate: x.GalaxyAttr("name"), | ||
| Tokenizer: []string{"int"}, | ||
| }, | ||
| }, | ||
| } | ||
| err = typeSanityCheck(typeDef) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "Field in type definition cannot have tokenizers") | ||
| } |