Skip to content

Clean up justfile and testing #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Apr 16, 2025

First commit:

  • Renames the just recipe for testing to test (instead of test-rust) and for building to build (instead of build-rust)
  • Reorders the justfile after category: building, testing, linting, rust-examples, artifacts, benchmarks, fuzzing, flatbuffrers
  • Modifies several crates' cargo.toml to set doctest=false, so that cargo test doesn't show noise (running 0 tests)
  • Removes the need to set environment variables for certain rust examples/tests

Second commit:

  • fixes a bug where the gdb test failed if the terminal size was too small (due to pagination).

@ludfjig ludfjig changed the title Clean up testing and justfile Clean up justfile Apr 16, 2025
@ludfjig ludfjig force-pushed the cleanup_testing branch 2 times, most recently from a5986de to e303648 Compare April 18, 2025 00:10
@ludfjig ludfjig changed the title Clean up justfile Clean up justfile and testing Apr 18, 2025
@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Apr 18, 2025
@ludfjig ludfjig force-pushed the cleanup_testing branch 3 times, most recently from d0e352a to 508e6a5 Compare April 18, 2025 17:34
@ludfjig ludfjig marked this pull request as ready for review April 18, 2025 17:59
Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to change any documentation that maybe used build-rust or alike? I saw the README uses just build already. Was it wrong or a different build?

@ludfjig
Copy link
Contributor Author

ludfjig commented Apr 21, 2025

Do we have to change any documentation that maybe used build-rust or alike? I saw the README uses just build already. Was it wrong or a different build?

We had a build recipe, but it was just forwarding to build-rust. Regarding references to old name, we don't have any

@ludfjig ludfjig merged commit 8c73c32 into hyperlight-dev:main Apr 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants