Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pollux): plugins #349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(Pollux): plugins #349

wants to merge 3 commits into from

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Dec 12, 2024

Description:

BREAKING CHANGES:

  • Pollux interface complete rewrite to plugins.

  • Anoncreds not available by default, needs to be loaded (if wanted).

  • removed

    • AttachmentFormats - known Didcomm Message formats, now internal to modules
    • Message.credentialFormat - used AttachmentFormats

    Helpers, a large number of helpers, intended for internal use but are technically exported in the Package, so listing below:

    • Domain.InputLimitDisclosure - specific to modules

    • Domain.DescriptorItemFormat - specific to modules

    • Domain.SDJWTVerifiableCredentialProperties - now use JWT.Claims | SDJWT_VP_PROPS instead

    • Domain.JWTVerifiableCredentialProperties - now use JWT.Claims | JWT_VP_PROPS instead

    • Domain.JWTVerifiablePresentationProperties - now use JWT.Claims | JWT_VC_PROPS | JWT_VP_PROPS instead

    • Domain.CredentialSubject

    • Domain.VerifiableCredentialTypeContainer

    • Domain.PredicateType

    • Domain.AttributeType

    • JWTPresentationClaims

    • SDJWTPresentationClaims

    • AnoncredsPresentationClaims

    • AnoncredsInputFieldFilter

    • InputFieldFilter

    • InputField

    • InputConstraints

    • InputDescriptor

    • DefinitionFormat

    • PresentationAnoncredsRequest

    • PresentationExchangeDefinitionRequest

    • PresentationDefinitionData

    • PresentationDefinitionRequestType

    • PresentationDefinitionRequest

    • DescriptorItem

    • JWTPresentationSubmission

    • SDJWTPresentationExchangeSubmission

    • SDJWTPresentationSubmission

    • AnoncredsPresentationSubmission

    • PresentationSubmissionData

    • PresentationSubmission

    • W3CVerifiableCredentialData

    • JWTRevocationStatusPurpose

    • CredentialStatusType

    • RevocationType

    • JWTRevocationStatus

    • JWTProofType

    • JWTProofPurpose

    • JWTStatusListResponse

    • JWTCredentialPayload

    • JWTPresentationPayload

    • Hasher

    • Signer

    • Verifier

    • JWTHeader

    • JWTPayload

    • PresentationJWTOptions

    • PresentationRequestOptions

    • PresentationOptions

    • AnoncredsPresentationOptions

    • SDJWPresentationOptions

    • JWTPresentationOptions

    • isPresentationDefinitionRequestType

Fixes:

  • docker hacks .replace("host.docker.internal")
  • decouple Protocols, Credentials, orchestration
    • reduce Pollux complexity
  • consolidating JWT code

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Dec 12, 2024
@curtis-h curtis-h changed the title Feat/pollux plugins feat(Pollux): plugins Jan 6, 2025
@curtis-h curtis-h force-pushed the feat/pollux-plugins branch 4 times, most recently from a6744c0 to cfa476a Compare January 15, 2025 14:49
@curtis-h curtis-h force-pushed the feat/pollux-plugins branch from cfa476a to ffe2e9c Compare January 15, 2025 15:37
Signed-off-by: Curtish <[email protected]>
@curtis-h curtis-h force-pushed the feat/pollux-plugins branch from ffe2e9c to 8769062 Compare January 15, 2025 15:46
Copy link

github-actions bot commented Jan 15, 2025

Lines Statements Branches Functions
Coverage: 77%
77.29% (3472/4492) 64.37% (1357/2108) 82.17% (885/1077)

@coveralls
Copy link

coveralls commented Jan 15, 2025

Coverage Status

coverage: 72.929% (-1.6%) from 74.558%
when pulling 047f03d on feat/pollux-plugins
into bda7c5f on main.

Signed-off-by: Curtish <[email protected]>
@curtis-h curtis-h force-pushed the feat/pollux-plugins branch from 8769062 to 047f03d Compare January 16, 2025 14:56
@curtis-h curtis-h marked this pull request as ready for review January 21, 2025 16:03
@curtis-h curtis-h requested a review from a team as a code owner January 21, 2025 16:03
@curtis-h curtis-h requested a review from elribonazo January 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants