Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backup): allow backup and import of prism wallet #143

Merged
merged 1 commit into from
May 28, 2024
Merged

feat(backup): allow backup and import of prism wallet #143

merged 1 commit into from
May 28, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented May 27, 2024 •
edited
Loading

Description:

This will enable backup of a wallet to another wallet given the seed is the same. It adds a protocol to enable credential exports.

Fixes ATL-6610

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@goncalo-frade-iohk
feat(backup): allow backup and import of prism wallet
3c9fae3 
This will enable backup of a wallet to another wallet given the seed is the same.
It adds a protocol to enable credential exports.

Fixes ATL-6610
yshyn-iohk
yshyn-iohk approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a beautiful code; sometimes I will try to use Swift :)

@goncalo-frade-iohk goncalo-frade-iohk merged commit e519192 into main May 28, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/backup2 branch May 28, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@hamada147 hamada147 Awaiting requested review from hamada147

@curtis-h curtis-h Awaiting requested review from curtis-h

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

@elribonazo elribonazo Awaiting requested review from elribonazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalo-frade-iohk @yshyn-iohk