Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pollux): add size and last used index to credential_status_lists table #798

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented Nov 24, 2023

Overview

this PR adds extra columns to credential_status_list, and removes proof because it is included inside a jwt credential as a asignature

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@shotexa shotexa marked this pull request as draft November 24, 2023 17:26
@shotexa shotexa changed the title Tmp title feat(pollux): add size and last used index to credential_status_lists table Nov 24, 2023
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ±0 
25 runs  ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7310b7f. ± Comparison against base commit 6133a3d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 24, 2023

Unit Test Results

  87 files  ±0    87 suites  ±0   21m 47s ⏱️ + 1m 2s
724 tests ±0  716 ✔️ ±0  8 💤 ±0  0 ±0 
730 runs  ±0  722 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 7310b7f. ± Comparison against base commit 6133a3d.

♻️ This comment has been updated with latest results.

Signed-off-by: Shota Jolbordi <[email protected]>
@shotexa shotexa marked this pull request as ready for review November 27, 2023 16:25
shotexa added 2 commits November 27, 2023 20:25
Signed-off-by: Shota Jolbordi <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shotexa shotexa requested a review from bvoiturier November 27, 2023 16:28
@shotexa shotexa merged commit f383698 into epic/ATL-4095-revocation-for-jwt-creds Nov 27, 2023
12 checks passed
@shotexa shotexa deleted the NO-JIRA-update-credenial-status-lists-table branch November 27, 2023 17:09
shotexa pushed a commit that referenced this pull request Dec 5, 2023
shotexa pushed a commit that referenced this pull request Mar 6, 2024
shotexa pushed a commit that referenced this pull request Mar 6, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants