Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve configuration for integration tests #796

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

antonbaliasnikov
Copy link

Overview

Improves configuration for integration tests:

  1. Allows containers to share services
  2. Minimize configuration parameters, but keep agility
  3. Add the capability to keep containers running
  4. Add different configs for basic/vault/keycloak/combined
  5. Replace Acme, Bob and Faber with Issuer, Holder and Verifier
  6. Optimizations and refactoring

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Copy link

sonarqubecloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

Integration Test Results

11 files  ±0  11 suites  ±0   1s ⏱️ -1s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ±0 
25 runs  ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b915c3a. ± Comparison against base commit f050e35.

Copy link
Contributor

Unit Test Results

  85 files  ±0    85 suites  ±0   21m 21s ⏱️ +37s
712 tests ±0  704 ✔️ ±0  8 💤 ±0  0 ±0 
718 runs  ±0  710 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit b915c3a. ± Comparison against base commit f050e35.

@antonbaliasnikov antonbaliasnikov merged commit 5e249bb into main Nov 24, 2023
12 checks passed
@antonbaliasnikov antonbaliasnikov deleted the configurable-int-tests-part-2 branch November 24, 2023 10:34
shotexa pushed a commit that referenced this pull request Dec 5, 2023
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Anton Baliasnikov <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants