Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(castor): clean up sonarcloud issues and unused configurations #784

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

patlo-iog
Copy link
Contributor

Overview

Partially fixes ATL-5374. Clean up some warning from sonarcloud analysis and remove unused configurations.

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@antonbaliasnikov
Copy link

@patlo-iog , awesome!

Please, don't forget to remove DEV_MODE from atala-prism-docs repository.

Copy link
Contributor

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ -2s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ±0 
25 runs  ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dc4378b. ± Comparison against base commit b99a737.

Copy link
Contributor

Atala PRISM Test Results

  84 files  ±0    84 suites  ±0   19m 47s ⏱️ +4s
695 tests  - 3  687 ✔️ ±0  8 💤  - 3  0 ±0 
701 runs   - 3  693 ✔️ ±0  8 💤  - 3  0 ±0 

Results for commit dc4378b. ± Comparison against base commit b99a737.

This pull request removes 3 tests.
io.iohk.atala.castor.core.util.DIDOperationValidatorSpec ‑ DIDOperationValidator - CreateOperation validation - reject CreateOperation when service URL is not normalized
io.iohk.atala.castor.core.util.DIDOperationValidatorSpec ‑ DIDOperationValidator - UpdateOperation validation - reject UpdateOperation when action AddService serviceEndpoint is not normalized
io.iohk.atala.castor.core.util.DIDOperationValidatorSpec ‑ DIDOperationValidator - UpdateOperation validation - reject updateOperation when action UpdateService serviceEndpoint is not normalized

@patlo-iog patlo-iog merged commit ec8ac69 into main Nov 13, 2023
10 checks passed
@patlo-iog patlo-iog deleted the fix/castor-sonar-issue branch November 13, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants