Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openAPI mutability #1115 #1494

Merged
merged 3 commits into from
Jan 15, 2025
Merged

fix: openAPI mutability #1115 #1494

merged 3 commits into from
Jan 15, 2025

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Jan 10, 2025

Description:

This PR fixes issue #1115: OAS is mutated from build to build because of Instant.now() and UUID.random() functions were used in the annotations.

I tried to implement the integration tests, but it's not trivial and fragile because the Tapir OAS is static and a lot of classes must be reloaded or isolated in the dedicated classloader.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk requested a review from a team as a code owner January 10, 2025 12:06
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) January 10, 2025 12:14
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ -1s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 01b487e. ± Comparison against base commit ec6caa5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Unit Test Results

104 files  ±0  104 suites  ±0   21m 9s ⏱️ + 1m 8s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 01b487e. ± Comparison against base commit ec6caa5.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 48.589% (-0.1%) from 48.691%
when pulling 01b487e on fix/1115
into ec6caa5 on main.

@yshyn-iohk yshyn-iohk merged commit 1e19b04 into main Jan 15, 2025
14 checks passed
@yshyn-iohk yshyn-iohk deleted the fix/1115 branch January 15, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants