fix: Add disclose claims to presentation record credential type SDJWT #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
mineme0110
changed the title
mineme0110
changed the title
Signed-off-by: mineme0110 <[email protected]>
yshyn-iohk
reviewed
Jan 7, 2025
| _ | ||
| ) => | ||
| ZIO.unit | ||
| case PresentationRecord(_, _, _, _, _, _, _, InvitationExpired, _, _, _, _, _, _, _, _, _, _, _, _, _, _) => | ||
| case PresentationRecord(_, _, _, _, _, _, _, InvitationExpired, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _) => |
There was a problem hiding this comment.
omg, my famous pattern matching :)
Do we have a task to refactor it?
yshyn-iohk
approved these changes
Jan 7, 2025
Signed-off-by: mineme0110 <[email protected]>
This was referenced Jan 7, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#1430
currently api does not display disclosed claim information. this endpoint to reveal disclosed claims for greater clarity
{{baseUrlVerifier}}/present-proof/presentations/{{VERIFIER_PRESENTATION_ID}}
This PR fixed the this issue
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: