Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support 'pollux.domain' config param #1483

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat: support 'pollux.domain' config param #1483

merged 2 commits into from
Dec 18, 2024

Conversation

bvoiturier
Copy link
Contributor

No description provided.

@bvoiturier bvoiturier requested a review from a team as a code owner December 17, 2024 13:15
@bvoiturier bvoiturier linked an issue Dec 17, 2024 that may be closed by this pull request
Make the configurable domain field for the credential issuance #1422
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Unit Test Results

104 files  ±0  104 suites  ±0   20m 16s ⏱️ -24s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit cab3d0b. ± Comparison against base commit 7524ec7.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ ±0s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cab3d0b. ± Comparison against base commit 7524ec7.

♻️ This comment has been updated with latest results.

yshyn-iohk
yshyn-iohk approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, @bvoiturier!
🚀

@bvoiturier
chore: run scalafmt
cab3d0b 
Signed-off-by: Benjamin Voiturier <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 48.794% (+0.05%) from 48.743%
when pulling cab3d0b on feat/1422-make-domain-field-configurable-for-vc-issuance
into 7524ec7 on main.

@bvoiturier bvoiturier merged commit 81350ea into main Dec 18, 2024
14 checks passed
@bvoiturier bvoiturier deleted the feat/1422-make-domain-field-configurable-for-vc-issuance branch December 18, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

Assignees
No one assigned
Labels
cloud-agent pollux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the configurable domain field for the credential issuance
3 participants
@bvoiturier @coveralls @yshyn-iohk