Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapping the claims attributes to json #1480

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Dec 13, 2024

Description:

mapped the claim attributes correctly in to json

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: mineme0110 <[email protected]>
@mineme0110 mineme0110 requested a review from a team as a code owner December 13, 2024 10:33
Signed-off-by: mineme0110 <[email protected]>
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) December 13, 2024 10:44
Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7f9cbde. ± Comparison against base commit 248ba5f.

Copy link
Contributor

Unit Test Results

104 files  ±0  104 suites  ±0   20m 28s ⏱️ +9s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 7f9cbde. ± Comparison against base commit 248ba5f.

@yshyn-iohk yshyn-iohk merged commit a96e544 into main Dec 13, 2024
17 of 18 checks passed
@yshyn-iohk yshyn-iohk deleted the fix-mapping-claims-sd-jwt branch December 13, 2024 10:51
@coveralls
Copy link

Coverage Status

coverage: 48.797% (-0.003%) from 48.8%
when pulling 7f9cbde on fix-mapping-claims-sd-jwt
into 248ba5f on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants