Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests for different createCredentialOffer API variations #1476

Merged
merged 22 commits into from
Jan 17, 2025

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Dec 12, 2024

Description:

The goal of this PR is to add tests for improved API to make a credentialOffer

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk requested a review from a team as a code owner December 12, 2024 11:52
@yshyn-iohk yshyn-iohk changed the title [WIP] test: add e2e tests for different createCredentialOffer API variations test: add e2e tests for different createCredentialOffer API variations Dec 12, 2024
@yshyn-iohk yshyn-iohk marked this pull request as draft December 12, 2024 12:06
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Unit Test Results

105 files  +1  105 suites  +1   20m 17s ⏱️ + 3m 31s
889 tests +7  881 ✅ +7  8 💤 ±0  0 ❌ ±0 
896 runs  +7  888 ✅ +7  8 💤 ±0  0 ❌ ±0 

Results for commit 797ce69. ± Comparison against base commit 1e19b04.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 48.674% (+0.09%) from 48.589%
when pulling 797ce69 on feat/vcdm1_1-tests
into 1e19b04 on main.

Signed-off-by: Yurii Shynbuiev <[email protected]>
…m1_1-tests

# Conflicts:
#	cloud-agent/client/kotlin/src/main/kotlin/org/hyperledger/identus/client/models/CreateIssueCredentialRecordRequest.kt
#	cloud-agent/service/server/src/main/scala/org/hyperledger/identus/issue/controller/IssueControllerImpl.scala
#	tests/integration-tests/build.gradle.kts
#	tests/performance-tests/agent-performance-tests-k6/package.json
#	tests/performance-tests/agent-performance-tests-k6/yarn.lock
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Yurii Shynbuiev <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Integration Test Results

 22 files  +2   22 suites  +2   3s ⏱️ -1s
 56 tests +1   56 ✅ +1  0 💤 ±0  0 ❌ ±0 
101 runs  +4  101 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 797ce69. ± Comparison against base commit 1e19b04.

♻️ This comment has been updated with latest results.

@yshyn-iohk yshyn-iohk marked this pull request as ready for review January 16, 2025 11:03
@yshyn-iohk yshyn-iohk changed the title test: add e2e tests for different createCredentialOffer API variations feat: add e2e tests for different createCredentialOffer API variations Jan 16, 2025
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk merged commit 2ce192e into main Jan 17, 2025
14 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/vcdm1_1-tests branch January 17, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants