chore: update models in kotlin client generator #1373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allain Magyar <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
amagyar-iohk
force-pushed
the
chore/client-generator
branch
from
301f60b to
2ef9431
Compare
shotexa
reviewed
Sep 24, 2024
Comment on lines
+3
to
+5
| * Please note: | ||
| * This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). | ||
| * Do not edit this file manually. |
There was a problem hiding this comment.
Is this file really auto-generated? there Is some commented out code here
There was a problem hiding this comment.
it was auto generated but then I added to openapi-generator to ignore it and added to git
shotexa
reviewed
Sep 24, 2024
| @@ -15,3 +16,5 @@ src/main/kotlin/org/hyperledger/identus/client/models/CredentialSubject.kt | |||
| src/main/kotlin/org/hyperledger/identus/client/models/DateTimeParameter.kt | |||
| src/main/kotlin/org/hyperledger/identus/client/models/DidParameter.kt | |||
| src/main/kotlin/org/hyperledger/identus/client/models/VcVerificationParameter.kt | |||
|
|
|||
| src/main/kotlin/org/hyperledger/identus/client/models/Json.kt | |||
There was a problem hiding this comment.
I'm probably not understanding something, but I thought initially that you will override Service(id, type, serviceEndpoint) type here, should not you also add it in this file as well?
shotexa
reviewed
Sep 24, 2024
| If there's no `discriminator` you'll have to try to parse each type to retrieve the typed object. | ||
|
|
||
| ```kotlin | ||
| class ServiceTypeAdapter : TypeAdapter<AnimalResponse>() { |
There was a problem hiding this comment.
should it be class AnimalResponseAdapter? 🤔
shotexa
reviewed
Sep 24, 2024
| out.jsonValue(Gson().toJson(value.value)) | ||
| } | ||
|
|
||
| fun JsonTypeAdapter.oleole() { |
There was a problem hiding this comment.
I guess you've been using this while developing and forgot to remove
|
@amagyar-iohk Are we still going to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds solution when OAS model generation doesn't handle
oneOfwellChecklist: