Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix wrongly generated TS client models #1239

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

patlo-iog
Copy link
Contributor

Description:

Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@patlo-iog patlo-iog requested review from amagyar-iohk and removed request for bvoiturier and yshyn-iohk July 1, 2024 14:01
Copy link
Contributor

@amagyar-iohk amagyar-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Integration Test Results

18 files  ±0  18 suites  ±0   2s ⏱️ ±0s
39 tests ±0  39 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec43913. ± Comparison against base commit 30ad04b.

♻️ This comment has been updated with latest results.

Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog enabled auto-merge (squash) July 1, 2024 14:20
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Results

 96 files  ±0   96 suites  ±0   22m 38s ⏱️ +44s
826 tests ±0  818 ✅ ±0  8 💤 ±0  0 ❌ ±0 
833 runs  ±0  825 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ec43913. ± Comparison against base commit 30ad04b.

@patlo-iog patlo-iog merged commit c87b25f into main Jul 1, 2024
12 checks passed
@patlo-iog patlo-iog deleted the fix-ts-client branch July 1, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants